Bump cosmossdk.io/client/v2 from 2.0.0-beta.4 to 2.0.0-beta.5 #2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [cosmossdk.io/client/v2](https://github.com/cosmos/cosmos-sdk) from 2.0.0-beta.4 to 2.0.0-beta.5. - [Release notes](https://github.com/cosmos/cosmos-sdk/releases) - [Changelog](https://github.com/cosmos/cosmos-sdk/blob/main/CHANGELOG.md) - [Commits](cosmos/cosmos-sdk@client/v2.0.0-beta.4...client/v2.0.0-beta.5) --- updated-dependencies: - dependency-name: cosmossdk.io/client/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
…ere's a new proofs.proto file.
SpicyLemon
approved these changes
Sep 30, 2024
|
Ugh... Breaking 3rd party protobuf change due to the bump in I'm not sure what we can do about that, so I'm gonna hold off on this PR for a bit. There's a good chance that we just accept it and move forward, but we need to consider the ramifications first. |
|
Created cosmos/ics23#376 to let them know about the breaking change. We'll wait on that a bit before deciding what to do here. |
|
Two things combine to make it very likely that this won't cause a problem:
Also, there isn't really a way to fix this since the updated proto is already out there; changing it back would cause another breaking change for anyone using this version. So we really only have two options:
Option 1 seems like the only realistic option to me, so I suggest we approve and merge this PR. |
SpicyLemon
previously approved these changes
Oct 7, 2024
SpicyLemon
approved these changes
Oct 7, 2024
iramiller
approved these changes
Oct 7, 2024
SpicyLemon
deleted the
dependabot/go_modules/cosmossdk.io/client/v2-2.0.0-beta.5
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps cosmossdk.io/client/v2 from 2.0.0-beta.4 to 2.0.0-beta.5.
Commits
25255e4feat(client/v2): use x/txAminoNameAsTypeURLoption in 0.50 (#21801)7ee3115feat(x/tx): addaminoNameAsTypeURLoption in aminojson encoder (backport #2...f812291chore: prepare v0.50.10 (#21498)b2ec2f6fix(runtime): fix option order (backport #21769) (#21771)9a0a76fdocs(x/circuit): display correct example (backport #21768) (#21773)3feb2c0docs: demonstrate how to wire custom ante handlers in 0.50 app_di (#21767)b21441cfeat(types/collections): addLegacyDeccollection value (backport #21693) (...f78ed49feat(x/genutil): add better error messages for genesis validation (backport #...fe37dfbdocs(x/authz): update grant docs (backport #21677) (#21700)ef8a575docs(client/debug): correctdebug raw-bytescommand example (backport #2167...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)